diff options
| author | Paul E. McKenney <paulmck@kernel.org> | 2022-01-03 15:07:09 +0100 |
|---|---|---|
| committer | Paul E. McKenney <paulmck@kernel.org> | 2022-02-02 02:24:39 +0100 |
| commit | 6b8646a9d37c6324cf994dbefb75f3eb20b109ab (patch) | |
| tree | 73ec2997a3895b304525f44f0f593ddcdef0d367 /kernel | |
| parent | rcutorture: Fix rcu_fwd_mutex deadlock (diff) | |
| download | linux-6b8646a9d37c6324cf994dbefb75f3eb20b109ab.tar.xz linux-6b8646a9d37c6324cf994dbefb75f3eb20b109ab.zip | |
torture: Wake up kthreads after storing task_struct pointer
Currently, _torture_create_kthread() uses kthread_run() to create
torture-test kthreads, which means that the resulting task_struct
pointer is stored after the newly created kthread has been marked
runnable. This in turn can cause spurious failure of checks for
code being run by a particular kthread. This commit therefore changes
_torture_create_kthread() to use kthread_create(), then to do an explicit
wake_up_process() after the task_struct pointer has been stored.
Reported-by: Frederic Weisbecker <frederic@kernel.org>
Reviewed-by: Neeraj Upadhyay <quic_neeraju@quicinc.com>
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/torture.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/torture.c b/kernel/torture.c index f55d803f995d..789aeb0e1159 100644 --- a/kernel/torture.c +++ b/kernel/torture.c @@ -931,12 +931,14 @@ int _torture_create_kthread(int (*fn)(void *arg), void *arg, char *s, char *m, int ret = 0; VERBOSE_TOROUT_STRING(m); - *tp = kthread_run(fn, arg, "%s", s); + *tp = kthread_create(fn, arg, "%s", s); if (IS_ERR(*tp)) { ret = PTR_ERR(*tp); TOROUT_ERRSTRING(f); *tp = NULL; + return ret; } + wake_up_process(*tp); // Process is sleeping, so ordering provided. torture_shuffle_task_register(*tp); return ret; } |