diff options
| author | Dmitry Rokosov <DDRokosov@sberdevices.ru> | 2022-05-24 20:14:43 +0200 |
|---|---|---|
| committer | Jonathan Cameron <Jonathan.Cameron@huawei.com> | 2022-06-19 18:22:48 +0200 |
| commit | 9354c224c9b4f55847a0de3e968cba2ebf15af3b (patch) | |
| tree | e60f469b992ce885e94ed51c47265966f4e7b734 /lib/test_module.c | |
| parent | iio:accel:kxcjk-1013: rearrange iio trigger get and register (diff) | |
| download | linux-9354c224c9b4f55847a0de3e968cba2ebf15af3b.tar.xz linux-9354c224c9b4f55847a0de3e968cba2ebf15af3b.zip | |
iio:accel:mxc4005: rearrange iio trigger get and register
IIO trigger interface function iio_trigger_get() should be called after
iio_trigger_register() (or its devm analogue) strictly, because of
iio_trigger_get() acquires module refcnt based on the trigger->owner
pointer, which is initialized inside iio_trigger_register() to
THIS_MODULE.
If this call order is wrong, the next iio_trigger_put() (from sysfs
callback or "delete module" path) will dereference "default" module
refcnt, which is incorrect behaviour.
Fixes: 47196620c82f ("iio: mxc4005: add data ready trigger for mxc4005")
Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20220524181150.9240-4-ddrokosov@sberdevices.ru
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'lib/test_module.c')
0 files changed, 0 insertions, 0 deletions