diff options
| author | Michael Ellerman <mpe@ellerman.id.au> | 2018-10-19 06:21:09 +0200 |
|---|---|---|
| committer | Steven Rostedt (VMware) <rostedt@goodmis.org> | 2018-12-22 14:21:03 +0100 |
| commit | 29924e5030969c55dbe68074215be5a1f14f1ff1 (patch) | |
| tree | 8c30ef84c9ce2bcd0fb62e9e12bde05207eb489c /lib | |
| parent | seq_buf: Make seq_buf_puts() null-terminate the buffer (diff) | |
| download | linux-29924e5030969c55dbe68074215be5a1f14f1ff1.tar.xz linux-29924e5030969c55dbe68074215be5a1f14f1ff1.zip | |
seq_buf: Use size_t for len in seq_buf_puts()
Jann Horn points out that we're using unsigned int for len in
seq_buf_puts(), which could potentially overflow if we're passed a
UINT_MAX sized string.
The rest of the code already uses size_t, so we should also use that
in seq_buf_puts() to avoid any issues.
Link: http://lkml.kernel.org/r/20181019042109.8064-2-mpe@ellerman.id.au
Suggested-by: Jann Horn <jannh@google.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/seq_buf.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/seq_buf.c b/lib/seq_buf.c index 6aabb609dd87..bd807f545a9d 100644 --- a/lib/seq_buf.c +++ b/lib/seq_buf.c @@ -140,7 +140,7 @@ int seq_buf_bprintf(struct seq_buf *s, const char *fmt, const u32 *binary) */ int seq_buf_puts(struct seq_buf *s, const char *str) { - unsigned int len = strlen(str); + size_t len = strlen(str); WARN_ON(s->size == 0); |