diff options
author | Dan Williams <dan.j.williams@intel.com> | 2018-07-14 06:50:01 +0200 |
---|---|---|
committer | Dave Jiang <dave.jiang@intel.com> | 2018-07-23 19:37:39 +0200 |
commit | 2fa147bdbf672c53386a8f5f2c7fe358004c3ef8 (patch) | |
tree | 7cf0718fabe780c0faf9337a6f8262826cb1dc37 /mm | |
parent | mm, madvise_inject_error: Disable MADV_SOFT_OFFLINE for ZONE_DEVICE pages (diff) | |
download | linux-2fa147bdbf672c53386a8f5f2c7fe358004c3ef8.tar.xz linux-2fa147bdbf672c53386a8f5f2c7fe358004c3ef8.zip |
mm, dev_pagemap: Do not clear ->mapping on final put
MEMORY_DEVICE_FS_DAX relies on typical page semantics whereby ->mapping
is only ever cleared by truncation, not final put.
Without this fix dax pages may forget their mapping association at the
end of every page pin event.
Move this atypical behavior that HMM wants into the HMM ->page_free()
callback.
Cc: <stable@vger.kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Fixes: d2c997c0f145 ("fs, dax: use page->mapping...")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Jérôme Glisse <jglisse@redhat.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/hmm.c | 2 |
1 files changed, 2 insertions, 0 deletions
@@ -963,6 +963,8 @@ static void hmm_devmem_free(struct page *page, void *data) { struct hmm_devmem *devmem = data; + page->mapping = NULL; + devmem->ops->free(devmem, page); } |