summaryrefslogtreecommitdiffstats
path: root/net/batman-adv
diff options
context:
space:
mode:
authorLinus Lüssing <linus.luessing@c0d3.blue>2021-05-17 00:33:08 +0200
committerSimon Wunderlich <sw@simonwunderlich.de>2021-05-17 12:00:44 +0200
commit4cbf055002c53c364d1b3275792e4487af76dd2d (patch)
treec2646ab5a4e14178b0064f2aa3970eec1e79d11b /net/batman-adv
parentbatman-adv: bcast: queue per interface, if needed (diff)
downloadlinux-4cbf055002c53c364d1b3275792e4487af76dd2d.tar.xz
linux-4cbf055002c53c364d1b3275792e4487af76dd2d.zip
batman-adv: bcast: avoid skb-copy for (re)queued broadcasts
Broadcast packets send via batadv_send_outstanding_bcast_packet() were originally copied in batadv_forw_bcast_packet_to_list() before being queued. And after that only the ethernet header will be pushed through batadv_send_broadcast_skb()->batadv_send_skb_packet() which works safely on skb clones as it uses batadv_skb_head_push()->skb_cow_head(). Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv')
-rw-r--r--net/batman-adv/send.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/send.c b/net/batman-adv/send.c
index 07b0ba265472..0b9dd29d3b6a 100644
--- a/net/batman-adv/send.c
+++ b/net/batman-adv/send.c
@@ -1072,7 +1072,7 @@ static void batadv_send_outstanding_bcast_packet(struct work_struct *work)
}
/* send a copy of the saved skb */
- skb1 = skb_copy(forw_packet->skb, GFP_ATOMIC);
+ skb1 = skb_clone(forw_packet->skb, GFP_ATOMIC);
if (!skb1)
goto out;