diff options
author | Jesse Brandeburg <jesse.brandeburg@intel.com> | 2009-03-25 23:05:21 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-03-26 09:09:59 +0100 |
commit | a72d2b2cc63994cb8d592a004bf5331be6905814 (patch) | |
tree | c55a5b6d1f471e0aae21881d3bce8b047c46baa4 /net/core | |
parent | e1000e: commonize tx cleanup routine to match e1000 & igb (diff) | |
download | linux-a72d2b2cc63994cb8d592a004bf5331be6905814.tar.xz linux-a72d2b2cc63994cb8d592a004bf5331be6905814.zip |
e1000e: fix loss of multicast packets
e1000e (and e1000, igb, ixgbe, ixgb) all do a series of operations each
time a multicast address is added. The flow goes something like
1) stack adds one multicast address
2) stack passes whole current list of unicast and multicast addresses to
driver
3) driver clears entire list in hardware
4) driver programs each multicast address using iomem in a loop
This was causing multicast packets to be lost during the reprogramming
process.
reference with test program:
http://kerneltrap.org/mailarchive/linux-netdev/2009/3/14/5160514/thread
Thanks to Dave Boutcher for his report and test program.
This driver fix prepares an array all at once in memory and programs it in
one shot to the hardware, not requiring an "erase" cycle. It would still
be possible for packets to be dropped while the receiver is off during
reprogramming.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
CC: Dave Boutcher <daveboutcher@gmail.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
0 files changed, 0 insertions, 0 deletions