diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-20 18:50:15 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-22 13:06:17 +0200 |
| commit | 706c6202a3589f290e1ef9be0584a8f4a3cc0507 (patch) | |
| tree | ddc3d4276299696711276fa93be5753c3586ed16 /net/ipv4 | |
| parent | tcp: Fix a data-race around sysctl_tcp_adv_win_scale. (diff) | |
| download | linux-706c6202a3589f290e1ef9be0584a8f4a3cc0507.tar.xz linux-706c6202a3589f290e1ef9be0584a8f4a3cc0507.zip | |
tcp: Fix a data-race around sysctl_tcp_frto.
While reading sysctl_tcp_frto, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 8cf4fbd349ab..af376d7423d1 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -2175,7 +2175,7 @@ void tcp_enter_loss(struct sock *sk) * loss recovery is underway except recurring timeout(s) on * the same SND.UNA (sec 3.2). Disable F-RTO on path MTU probing */ - tp->frto = net->ipv4.sysctl_tcp_frto && + tp->frto = READ_ONCE(net->ipv4.sysctl_tcp_frto) && (new_recovery || icsk->icsk_retransmits) && !inet_csk(sk)->icsk_mtup.probe_size; } |