summaryrefslogtreecommitdiffstats
path: root/net/l2tp
diff options
context:
space:
mode:
authorTom Parkin <tparkin@katalix.com>2020-07-24 17:31:56 +0200
committerDavid S. Miller <davem@davemloft.net>2020-07-25 02:19:14 +0200
commit0dd62f69d898de3cf31a2f8b59e9a62bb5448457 (patch)
tree7cc790cb310b70f5751706700e6ca4fb36bdffed /net/l2tp
parentl2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge (diff)
downloadlinux-0dd62f69d898de3cf31a2f8b59e9a62bb5448457.tar.xz
linux-0dd62f69d898de3cf31a2f8b59e9a62bb5448457.zip
l2tp: remove BUG_ON refcount value in l2tp_session_free
l2tp_session_free is only called by l2tp_session_dec_refcount when the reference count reaches zero, so it's of limited value to validate the reference count value in l2tp_session_free itself. Signed-off-by: Tom Parkin <tparkin@katalix.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp')
-rw-r--r--net/l2tp/l2tp_core.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c
index e228480fa529..50548c61b91e 100644
--- a/net/l2tp/l2tp_core.c
+++ b/net/l2tp/l2tp_core.c
@@ -1563,8 +1563,6 @@ void l2tp_session_free(struct l2tp_session *session)
{
struct l2tp_tunnel *tunnel = session->tunnel;
- BUG_ON(refcount_read(&session->ref_count) != 0);
-
if (tunnel) {
BUG_ON(tunnel->magic != L2TP_TUNNEL_MAGIC);
l2tp_tunnel_dec_refcount(tunnel);