diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2009-12-12 23:11:15 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-12-14 04:45:22 +0100 |
| commit | d90a909e1f3e006a1d57fe11fd417173b6494701 (patch) | |
| tree | 72893da9ed5083b44dbb8d778d648e114d351a0a /net/nonet.c | |
| parent | udp: udp_lib_get_port() fix (diff) | |
| download | linux-d90a909e1f3e006a1d57fe11fd417173b6494701.tar.xz linux-d90a909e1f3e006a1d57fe11fd417173b6494701.zip | |
net: Fix userspace RTM_NEWLINK notifications.
I received some bug reports about userspace programs having problems
because after RTM_NEWLINK was received they could not immediate access
files under /proc/sys/net/ because they had not been registered yet.
The original problem was trivially fixed by moving the userspace
notification from rtnetlink_event() to the end of
register_netdevice().
When testing that change I discovered I was still getting RTM_NEWLINK
events before I could access proc and I was also getting RTM_NEWLINK
events after I was seeing RTM_DELLINK. Things practically guaranteed
to confuse userspace.
After a little more investigation these extra notifications proved to
be from the new notifiers NETDEV_POST_INIT and NETDEV_UNREGISTER_BATCH
hitting the default case in rtnetlink_event, and triggering
unnecessary RTM_NEWLINK messages.
rtnetlink_event now explicitly handles NETDEV_UNREGISTER_BATCH and
NETDEV_POST_INIT to avoid sending the incorrect userspace
notifications.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/nonet.c')
0 files changed, 0 insertions, 0 deletions