summaryrefslogtreecommitdiffstats
path: root/net/strparser/Kconfig
diff options
context:
space:
mode:
authorNick Child <nnac123@linux.ibm.com>2024-06-20 17:23:11 +0200
committerPaolo Abeni <pabeni@redhat.com>2024-06-25 10:43:42 +0200
commit0983d288caf984de0202c66641577b739caad561 (patch)
treeaa8f19beb0cbfee46a244d281d69d6806c758240 /net/strparser/Kconfig
parentMerge tag 'for-netdev' of ssh://gitolite.kernel.org/pub/scm/linux/kernel/git/... (diff)
downloadlinux-0983d288caf984de0202c66641577b739caad561.tar.xz
linux-0983d288caf984de0202c66641577b739caad561.zip
ibmvnic: Add tx check to prevent skb leak
Below is a summary of how the driver stores a reference to an skb during transmit: tx_buff[free_map[consumer_index]]->skb = new_skb; free_map[consumer_index] = IBMVNIC_INVALID_MAP; consumer_index ++; Where variable data looks like this: free_map == [4, IBMVNIC_INVALID_MAP, IBMVNIC_INVALID_MAP, 0, 3] consumer_index^ tx_buff == [skb=null, skb=<ptr>, skb=<ptr>, skb=null, skb=null] The driver has checks to ensure that free_map[consumer_index] pointed to a valid index but there was no check to ensure that this index pointed to an unused/null skb address. So, if, by some chance, our free_map and tx_buff lists become out of sync then we were previously risking an skb memory leak. This could then cause tcp congestion control to stop sending packets, eventually leading to ETIMEDOUT. Therefore, add a conditional to ensure that the skb address is null. If not then warn the user (because this is still a bug that should be patched) and free the old pointer to prevent memleak/tcp problems. Signed-off-by: Nick Child <nnac123@linux.ibm.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'net/strparser/Kconfig')
0 files changed, 0 insertions, 0 deletions