summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorAlexander Aring <aahringo@redhat.com>2022-06-13 06:37:34 +0200
committerStefan Schmidt <stefan@datenfreihafen.org>2022-06-14 10:23:00 +0200
commit2ec2f6bed4d12a7ed74ed179a5d2879b117105d1 (patch)
tree703de23024d92b8967ba6bb6e9f112374b471e79 /net
parentnet: mac802154: Add a warning in the slow path (diff)
downloadlinux-2ec2f6bed4d12a7ed74ed179a5d2879b117105d1.tar.xz
linux-2ec2f6bed4d12a7ed74ed179a5d2879b117105d1.zip
mac802154: util: fix release queue handling
The semantic of atomic_dec_and_test() is to return true if zero is reached and we need call ieee802154_wake_queue() when zero is reached. Fixes: 20a19d1df3e4 ("net: mac802154: Bring the ability to hold the transmit queue") Signed-off-by: Alexander Aring <aahringo@redhat.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/r/20220613043735.1039895-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Diffstat (limited to 'net')
-rw-r--r--net/mac802154/util.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/mac802154/util.c b/net/mac802154/util.c
index 60eb7bd3bfc1..60f6c0f10641 100644
--- a/net/mac802154/util.c
+++ b/net/mac802154/util.c
@@ -79,7 +79,7 @@ void ieee802154_release_queue(struct ieee802154_local *local)
unsigned long flags;
spin_lock_irqsave(&local->phy->queue_lock, flags);
- if (!atomic_dec_and_test(&local->phy->hold_txs))
+ if (atomic_dec_and_test(&local->phy->hold_txs))
ieee802154_wake_queue(&local->hw);
spin_unlock_irqrestore(&local->phy->queue_lock, flags);
}