summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2015-07-02 18:38:12 +0200
committerDavid S. Miller <davem@davemloft.net>2015-07-03 18:27:43 +0200
commit92b80eb33c52583b48ed289bd993579b87b52d9a (patch)
treea9a6fe3a9a2f52be6fa4edbc141b81b30b6f27ae /net
parentnet-RDS: Delete an unnecessary check before the function call "module_put" (diff)
downloadlinux-92b80eb33c52583b48ed289bd993579b87b52d9a.tar.xz
linux-92b80eb33c52583b48ed289bd993579b87b52d9a.zip
netlink: Delete an unnecessary check before the function call "module_put"
The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/netlink/af_netlink.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index dea925388a5b..9a0ae7172f92 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -158,7 +158,7 @@ static int __netlink_remove_tap(struct netlink_tap *nt)
out:
spin_unlock(&netlink_tap_lock);
- if (found && nt->module)
+ if (found)
module_put(nt->module);
return found ? 0 : -ENODEV;