diff options
| author | Heng Guo <heng.guo@windriver.com> | 2023-08-25 09:55:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-08-30 10:44:09 +0200 |
| commit | e4da8c78973c1e307c0431e0b99a969ffb8aa3f1 (patch) | |
| tree | 9858c454a8dc159ef4db96143460b2af286c86e4 /samples/bpf | |
| parent | Merge tag 'net-next-6.6' of git://git.kernel.org/pub/scm/linux/kernel/git/net... (diff) | |
| download | linux-e4da8c78973c1e307c0431e0b99a969ffb8aa3f1.tar.xz linux-e4da8c78973c1e307c0431e0b99a969ffb8aa3f1.zip | |
net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated
commit edf391ff1723 ("snmp: add missing counters for RFC 4293") had
already added OutOctets for RFC 4293. In commit 2d8dbb04c63e ("snmp: fix
OutOctets counter to include forwarded datagrams"), OutOctets was
counted again, but not removed from ip_output().
According to RFC 4293 "3.2.3. IP Statistics Tables",
ipipIfStatsOutTransmits is not equal to ipIfStatsOutForwDatagrams. So
"IPSTATS_MIB_OUTOCTETS must be incremented when incrementing" is not
accurate. And IPSTATS_MIB_OUTOCTETS should be counted after fragment.
This patch reverts commit 2d8dbb04c63e ("snmp: fix OutOctets counter to
include forwarded datagrams") and move IPSTATS_MIB_OUTOCTETS to
ip_finish_output2 for ipv4.
Reviewed-by: Filip Pudak <filip.pudak@windriver.com>
Signed-off-by: Heng Guo <heng.guo@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'samples/bpf')
0 files changed, 0 insertions, 0 deletions