diff options
author | Jiri Olsa <jolsa@redhat.com> | 2021-12-19 14:53:17 +0100 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2022-01-06 00:34:50 +0100 |
commit | 0daf5cb217a9ca8ae91b8f966ddae322699fb71d (patch) | |
tree | 488ac3e754de1a89362d23709a5ffe2df08a87f1 /samples/ftrace/ftrace-direct.c | |
parent | tracing: Fix possible memory leak in __create_synth_event() error path (diff) | |
download | linux-0daf5cb217a9ca8ae91b8f966ddae322699fb71d.tar.xz linux-0daf5cb217a9ca8ae91b8f966ddae322699fb71d.zip |
ftrace/samples: Add missing prototypes direct functions
There's another compilation fail (first here [1]) reported by kernel
test robot for W=1 clang build:
>> samples/ftrace/ftrace-direct-multi-modify.c:7:6: warning: no previous
prototype for function 'my_direct_func1' [-Wmissing-prototypes]
void my_direct_func1(unsigned long ip)
Direct functions in ftrace direct sample modules need to have prototypes
defined. They are already global in order to be visible for the inline
assembly, so there's no problem.
The kernel test robot reported just error for ftrace-direct-multi-modify,
but I got same errors also for the rest of the modules touched by this patch.
[1] 67d4f6e3bf5d ftrace/samples: Add missing prototype for my_direct_func
Link: https://lkml.kernel.org/r/20211219135317.212430-1-jolsa@kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Fixes: e1067a07cfbc ("ftrace/samples: Add module to test multi direct modify interface")
Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
Fixes: 156473a0ff4f ("ftrace: Add another example of register_ftrace_direct() use case")
Fixes: b06457c83af6 ("ftrace: Add sample module that uses register_ftrace_direct()")
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'samples/ftrace/ftrace-direct.c')
-rw-r--r-- | samples/ftrace/ftrace-direct.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/samples/ftrace/ftrace-direct.c b/samples/ftrace/ftrace-direct.c index a30aa42ec76a..c918b13edb49 100644 --- a/samples/ftrace/ftrace-direct.c +++ b/samples/ftrace/ftrace-direct.c @@ -5,6 +5,8 @@ #include <linux/ftrace.h> #include <asm/asm-offsets.h> +extern void my_direct_func(struct task_struct *p); + void my_direct_func(struct task_struct *p) { trace_printk("waking up %s-%d\n", p->comm, p->pid); |