summaryrefslogtreecommitdiffstats
path: root/samples/mei
diff options
context:
space:
mode:
authorFilipe Manana <fdmanana@suse.com>2024-06-14 15:50:47 +0200
committerDavid Sterba <dsterba@suse.com>2024-07-11 15:33:26 +0200
commitbb3868033a4cccff7be57e9145f2117cbdc91c11 (patch)
treeab2d9bc127c05365303ff5e955a7edfabd5b29ef /samples/mei
parentbtrfs: remove super block argument from btrfs_iget_locked() (diff)
downloadlinux-bb3868033a4cccff7be57e9145f2117cbdc91c11.tar.xz
linux-bb3868033a4cccff7be57e9145f2117cbdc91c11.zip
btrfs: do not BUG_ON() when freeing tree block after error
When freeing a tree block, at btrfs_free_tree_block(), if we fail to create a delayed reference we don't deal with the error and just do a BUG_ON(). The error most likely to happen is -ENOMEM, and we have a comment mentioning that only -ENOMEM can happen, but that is not true, because in case qgroups are enabled any error returned from btrfs_qgroup_trace_extent_post() (can be -EUCLEAN or anything returned from btrfs_search_slot() for example) can be propagated back to btrfs_free_tree_block(). So stop doing a BUG_ON() and return the error to the callers and make them abort the transaction to prevent leaking space. Syzbot was triggering this, likely due to memory allocation failure injection. Reported-by: syzbot+a306f914b4d01b3958fe@syzkaller.appspotmail.com Link: https://lore.kernel.org/linux-btrfs/000000000000fcba1e05e998263c@google.com/ Reviewed-by: Qu Wenruo <wqu@suse.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'samples/mei')
0 files changed, 0 insertions, 0 deletions