summaryrefslogtreecommitdiffstats
path: root/security/apparmor
diff options
context:
space:
mode:
authorJohn Johansen <john.johansen@canonical.com>2016-04-12 01:57:19 +0200
committerJohn Johansen <john.johansen@canonical.com>2016-07-12 17:43:10 +0200
commitec34fa24a934f4c8fd68f39b84abf34c42e5b06a (patch)
tree1ffe3fcae38b932de7ace29fed87dd4e98cf768a /security/apparmor
parentapparmor: fix refcount bug in profile replacement (diff)
downloadlinux-ec34fa24a934f4c8fd68f39b84abf34c42e5b06a.tar.xz
linux-ec34fa24a934f4c8fd68f39b84abf34c42e5b06a.zip
apparmor: fix replacement bug that adds new child to old parent
When set atomic replacement is used and the parent is updated before the child, and the child did not exist in the old parent so there is no direct replacement then the new child is incorrectly added to the old parent. This results in the new parent not having the child(ren) that it should and the old parent when being destroyed asserting the following error. AppArmor: policy_destroy: internal error, policy '<profile/name>' still contains profiles Signed-off-by: John Johansen <john.johansen@canonical.com> Acked-by: Seth Arnold <seth.arnold@canonical.com>
Diffstat (limited to 'security/apparmor')
-rw-r--r--security/apparmor/policy.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/policy.c b/security/apparmor/policy.c
index 222052f64e2c..c92a9f6c1be5 100644
--- a/security/apparmor/policy.c
+++ b/security/apparmor/policy.c
@@ -1193,7 +1193,7 @@ ssize_t aa_replace_profiles(void *udata, size_t size, bool noreplace)
/* aafs interface uses replacedby */
rcu_assign_pointer(ent->new->replacedby->profile,
aa_get_profile(ent->new));
- __list_add_profile(&parent->base.profiles, ent->new);
+ __list_add_profile(&newest->base.profiles, ent->new);
aa_put_profile(newest);
} else {
/* aafs interface uses replacedby */