diff options
author | Keith Busch <keith.busch@intel.com> | 2015-10-15 21:38:48 +0200 |
---|---|---|
committer | Jens Axboe <axboe@fb.com> | 2015-10-15 21:38:48 +0200 |
commit | 0dfc70c33409afc232ef0b9ec210535dfbf9bc61 (patch) | |
tree | 3ce38a73734b4a16364b1f2ba59a45df95dcdb6b /security/security.c | |
parent | block: don't release bdi while request_queue has live references (diff) | |
download | linux-0dfc70c33409afc232ef0b9ec210535dfbf9bc61.tar.xz linux-0dfc70c33409afc232ef0b9ec210535dfbf9bc61.zip |
NVMe: Fix memory leak on retried commands
Resources are reallocated for requeued commands, so unmap and release
the iod for the failed command.
It's a pretty bad memory leak and causes a kernel hang if you remove a
drive because of a busy dma pool. You'll get messages spewing like this:
nvme 0000:xx:xx.x: dma_pool_destroy prp list 256, ffff880420dec000 busy
and lock up pci and the driver since removal never completes while
holding a lock.
Cc: stable@vger.kernel.org
Cc: <stable@vger.kernel.org> # 4.0.x-
Signed-off-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'security/security.c')
0 files changed, 0 insertions, 0 deletions