diff options
| author | Takashi Iwai <tiwai@suse.de> | 2019-11-08 17:56:26 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2019-11-09 18:02:11 +0100 |
| commit | 2406ff9b86aa1b77fe1a6d15f37195ac1fdb2a14 (patch) | |
| tree | faecf0d28a81fe39c037ca47d7ed87b2254f4649 /sound/core | |
| parent | ALSA: timer: Fix possible race at assigning a timer instance (diff) | |
| download | linux-2406ff9b86aa1b77fe1a6d15f37195ac1fdb2a14.tar.xz linux-2406ff9b86aa1b77fe1a6d15f37195ac1fdb2a14.zip | |
ALSA: pcm: Yet another missing check of non-cached buffer type
For non-x86 architectures, SNDRV_DMA_TYPE_DEV_UC should be treated
equivalent with SNDRV_DMA_TYPE_DEV, where the default mmap handler
still checks only about SNDRV_DMA_TYPE_DEV. Make the check more
proper.
Note that all existing users of *_UC buffer types are x86-only, so
this doesn't fix any bug, but just for consistency.
Fixes: 42e748a0b325 ("ALSA: memalloc: Add non-cached buffer type")
Link: https://lore.kernel.org/r/20191108165626.5947-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core')
| -rw-r--r-- | sound/core/pcm_native.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 998c63192ae4..0c27009dc3df 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -3416,7 +3416,8 @@ int snd_pcm_lib_default_mmap(struct snd_pcm_substream *substream, #endif /* CONFIG_GENERIC_ALLOCATOR */ #ifndef CONFIG_X86 /* for avoiding warnings arch/x86/mm/pat.c */ if (IS_ENABLED(CONFIG_HAS_DMA) && !substream->ops->page && - substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV) + (substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV || + substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV_UC)) return dma_mmap_coherent(substream->dma_buffer.dev.dev, area, substream->runtime->dma_area, |