summaryrefslogtreecommitdiffstats
path: root/sound/pci/hda/hda_intel.c
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-17 10:44:33 +0100
committerTakashi Iwai <tiwai@suse.de>2014-11-17 13:45:23 +0100
commitf0acd28c87ad2a5d1b40403fdd5defda2961b2a1 (patch)
tree1ccd31d0a0a5fb4173b4953c966239897bc1c0c2 /sound/pci/hda/hda_intel.c
parentALSA: ice1712: consider error value (diff)
downloadlinux-f0acd28c87ad2a5d1b40403fdd5defda2961b2a1.tar.xz
linux-f0acd28c87ad2a5d1b40403fdd5defda2961b2a1.zip
ALSA: hda: Deletion of unnecessary checks before two function calls
The functions kfree() and release_firmware() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/hda/hda_intel.c')
-rw-r--r--sound/pci/hda/hda_intel.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 9ab1e631cb32..91fa959d05fe 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1130,8 +1130,7 @@ static int azx_free(struct azx *chip)
pci_disable_device(chip->pci);
kfree(chip->azx_dev);
#ifdef CONFIG_SND_HDA_PATCH_LOADER
- if (chip->fw)
- release_firmware(chip->fw);
+ release_firmware(chip->fw);
#endif
if (chip->driver_caps & AZX_DCAPS_I915_POWERWELL) {
hda_display_power(false);