summaryrefslogtreecommitdiffstats
path: root/sound/soc/amd
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2018-11-26 09:13:07 +0100
committerMark Brown <broonie@kernel.org>2018-11-26 13:22:56 +0100
commit83b12c2e1d942459f420490d4219fc1ad38c3620 (patch)
tree858eef248544cb2d5a7ddd35b5ac241b89bdac2e /sound/soc/amd
parentASoC: audio-graph-card: tidyup define position (diff)
downloadlinux-83b12c2e1d942459f420490d4219fc1ad38c3620.tar.xz
linux-83b12c2e1d942459f420490d4219fc1ad38c3620.zip
ASoC: amd: Fix a NULL vs IS_ERR() check in probe
The platform_device_register_full() function doesn't return NULL, it returns error pointers. Fixes: 7894a7e7ea3d ("ASoC: amd: create ACP3x PCM platform device") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/amd')
-rw-r--r--sound/soc/amd/raven/pci-acp3x.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c
index c28457fd9b81..facec2472b34 100644
--- a/sound/soc/amd/raven/pci-acp3x.c
+++ b/sound/soc/amd/raven/pci-acp3x.c
@@ -97,10 +97,10 @@ static int snd_acp3x_probe(struct pci_dev *pci,
pdevinfo.size_data = sizeof(irqflags);
adata->pdev = platform_device_register_full(&pdevinfo);
- if (!adata->pdev) {
+ if (IS_ERR(adata->pdev)) {
dev_err(&pci->dev, "cannot register %s device\n",
pdevinfo.name);
- ret = -ENODEV;
+ ret = PTR_ERR(adata->pdev);
goto unmap_mmio;
}
break;