summaryrefslogtreecommitdiffstats
path: root/sound/soc/codecs/wm5110.h
diff options
context:
space:
mode:
authorWayne Lin <Wayne.Lin@amd.com>2023-04-17 11:08:12 +0200
committerAlex Deucher <alexander.deucher@amd.com>2023-06-15 23:55:41 +0200
commit72f1de49ffb90b29748284f27f1d6b829ab1de95 (patch)
tree4718fd6c808c85a4f8a4639a59fbc1cecc52d5b7 /sound/soc/codecs/wm5110.h
parentdrm/amdgpu: Increase hmm range get pages timeout (diff)
downloadlinux-72f1de49ffb90b29748284f27f1d6b829ab1de95.tar.xz
linux-72f1de49ffb90b29748284f27f1d6b829ab1de95.zip
drm/dp_mst: Clear MSG_RDY flag before sending new message
[Why] The sequence for collecting down_reply from source perspective should be: Request_n->repeat (get partial reply of Request_n->clear message ready flag to ack DPRX that the message is received) till all partial replies for Request_n are received->new Request_n+1. Now there is chance that drm_dp_mst_hpd_irq() will fire new down request in the tx queue when the down reply is incomplete. Source is restricted to generate interveleaved message transactions so we should avoid it. Also, while assembling partial reply packets, reading out DPCD DOWN_REP Sideband MSG buffer + clearing DOWN_REP_MSG_RDY flag should be wrapped up as a complete operation for reading out a reply packet. Kicking off a new request before clearing DOWN_REP_MSG_RDY flag might be risky. e.g. If the reply of the new request has overwritten the DPRX DOWN_REP Sideband MSG buffer before source writing one to clear DOWN_REP_MSG_RDY flag, source then unintentionally flushes the reply for the new request. Should handle the up request in the same way. [How] Separete drm_dp_mst_hpd_irq() into 2 steps. After acking the MST IRQ event, driver calls drm_dp_mst_hpd_irq_send_new_request() and might trigger drm_dp_mst_kick_tx() only when there is no on going message transaction. Changes since v1: * Reworked on review comments received -> Adjust the fix to let driver explicitly kick off new down request when mst irq event is handled and acked -> Adjust the commit message Changes since v2: * Adjust the commit message * Adjust the naming of the divided 2 functions and add a new input parameter "ack". * Adjust code flow as per review comments. Changes since v3: * Update the function description of drm_dp_mst_hpd_irq_handle_event Changes since v4: * Change ack of drm_dp_mst_hpd_irq_handle_event() to be an array align the size of esi[] Signed-off-by: Wayne Lin <Wayne.Lin@amd.com> Reviewed-by: Lyude Paul <lyude@redhat.com> Acked-by: Jani Nikula <jani.nikula@intel.com> Cc: stable@vger.kernel.org Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Diffstat (limited to 'sound/soc/codecs/wm5110.h')
0 files changed, 0 insertions, 0 deletions