summaryrefslogtreecommitdiffstats
path: root/sound/soc/sof/sof-of-dev.c
diff options
context:
space:
mode:
authorChen-Yu Tsai <wenst@chromium.org>2023-12-04 04:35:47 +0100
committerMark Brown <broonie@kernel.org>2023-12-04 18:02:15 +0100
commitd0ae9dc48e24f5f704abcbb2dca3e4651bf0ff59 (patch)
tree040d273bbd9da607fe5d2eb56467353b46857b52 /sound/soc/sof/sof-of-dev.c
parentASoC: Convert Cirrus codecs to GPIO descriptors (diff)
downloadlinux-d0ae9dc48e24f5f704abcbb2dca3e4651bf0ff59.tar.xz
linux-d0ae9dc48e24f5f704abcbb2dca3e4651bf0ff59.zip
ASoC: SOF: Move sof_of_machine_select() to core.c from sof-of-dev.c
Commit 014fdeb0d747 ("ASoC: SOF: Move sof_of_machine_select() to sof-of-dev.c from sof-audio.c") caused a circular dependency between the snd_sof and snd_sof_of modules: depmod: ERROR: Cycle detected: snd_sof -> snd_sof_of -> snd_sof depmod: ERROR: Found 2 modules in dependency cycles! Move the function back with sof_machine_select(). Fixes: 014fdeb0d747 ("ASoC: SOF: Move sof_of_machine_select() to sof-of-dev.c from sof-audio.c") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Acked-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Link: https://lore.kernel.org/r/20231204033549.2020289-1-wenst@chromium.org Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/sof/sof-of-dev.c')
-rw-r--r--sound/soc/sof/sof-of-dev.c23
1 files changed, 0 insertions, 23 deletions
diff --git a/sound/soc/sof/sof-of-dev.c b/sound/soc/sof/sof-of-dev.c
index fa92da5ee9b3..b9a499e92b9a 100644
--- a/sound/soc/sof/sof-of-dev.c
+++ b/sound/soc/sof/sof-of-dev.c
@@ -41,29 +41,6 @@ static void sof_of_probe_complete(struct device *dev)
pm_runtime_enable(dev);
}
-struct snd_sof_of_mach *sof_of_machine_select(struct snd_sof_dev *sdev)
-{
- struct snd_sof_pdata *sof_pdata = sdev->pdata;
- const struct sof_dev_desc *desc = sof_pdata->desc;
- struct snd_sof_of_mach *mach = desc->of_machines;
-
- if (!mach)
- return NULL;
-
- for (; mach->compatible; mach++) {
- if (of_machine_is_compatible(mach->compatible)) {
- sof_pdata->tplg_filename = mach->sof_tplg_filename;
- if (mach->fw_filename)
- sof_pdata->fw_filename = mach->fw_filename;
-
- return mach;
- }
- }
-
- return NULL;
-}
-EXPORT_SYMBOL(sof_of_machine_select);
-
int sof_of_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;