summaryrefslogtreecommitdiffstats
path: root/tools/perf/bench
diff options
context:
space:
mode:
authorIan Rogers <irogers@google.com>2023-10-09 20:39:06 +0200
committerNamhyung Kim <namhyung@kernel.org>2023-10-12 19:01:55 +0200
commitda0c884b0756fc97a1c15f4cdb81e0a8490a6d7e (patch)
treeabea99d02dc1db1279da8bfce1a011bebee8df84 /tools/perf/bench
parentrun-clang-tools: Add pass through checks and and header-filter arguments (diff)
downloadlinux-da0c884b0756fc97a1c15f4cdb81e0a8490a6d7e.tar.xz
linux-da0c884b0756fc97a1c15f4cdb81e0a8490a6d7e.zip
perf bench uprobe: Fix potential use of memory after free
Found by clang-tidy: ``` bench/uprobe.c:98:3: warning: Use of memory after it is freed [clang-analyzer-unix.Malloc] bench_uprobe_bpf__destroy(skel); ``` Signed-off-by: Ian Rogers <irogers@google.com> Acked-by: Namhyung Kim <namhyung@kernel.org> Cc: Ravi Bangoria <ravi.bangoria@amd.com> Cc: Nick Desaulniers <ndesaulniers@google.com> Cc: Yang Jihong <yangjihong1@huawei.com> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Nathan Chancellor <nathan@kernel.org> Cc: Kan Liang <kan.liang@linux.intel.com> Cc: llvm@lists.linux.dev Cc: Ming Wang <wangming01@loongson.cn> Cc: Tom Rix <trix@redhat.com> Cc: bpf@vger.kernel.org Link: https://lore.kernel.org/r/20231009183920.200859-6-irogers@google.com Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'tools/perf/bench')
-rw-r--r--tools/perf/bench/uprobe.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/perf/bench/uprobe.c b/tools/perf/bench/uprobe.c
index 914c0817fe8a..5c71fdc419dd 100644
--- a/tools/perf/bench/uprobe.c
+++ b/tools/perf/bench/uprobe.c
@@ -89,6 +89,7 @@ static int bench_uprobe__setup_bpf_skel(enum bench_uprobe bench)
return err;
cleanup:
bench_uprobe_bpf__destroy(skel);
+ skel = NULL;
return err;
}