summaryrefslogtreecommitdiffstats
path: root/tools/testing/selftests/bpf/progs/exhandler_kern.c
diff options
context:
space:
mode:
authorYonghong Song <yhs@fb.com>2022-04-19 06:32:30 +0200
committerAlexei Starovoitov <ast@kernel.org>2022-04-19 19:18:56 +0200
commit8c89b5db7a2894e33417dd69680729e8f65f5709 (patch)
tree2f830b800102f5fe091d5afd59cac7ed8e5e9210 /tools/testing/selftests/bpf/progs/exhandler_kern.c
parentbpf: Move rcu lock management out of BPF_PROG_RUN routines (diff)
downloadlinux-8c89b5db7a2894e33417dd69680729e8f65f5709.tar.xz
linux-8c89b5db7a2894e33417dd69680729e8f65f5709.zip
selftests/bpf: Limit unroll_count for pyperf600 test
LLVM commit [1] changed loop pragma behavior such that full loop unroll is always honored with user pragma. Previously, unroll count also depends on the unrolled code size. For pyperf600, without [1], the loop unroll count is 150. With [1], the loop unroll count is 600. The unroll count of 600 caused the program size close to 298k and this caused the following code is generated: 0: 7b 1a 00 ff 00 00 00 00 *(u64 *)(r10 - 256) = r1 ; uint64_t pid_tgid = bpf_get_current_pid_tgid(); 1: 85 00 00 00 0e 00 00 00 call 14 2: bf 06 00 00 00 00 00 00 r6 = r0 ; pid_t pid = (pid_t)(pid_tgid >> 32); 3: bf 61 00 00 00 00 00 00 r1 = r6 4: 77 01 00 00 20 00 00 00 r1 >>= 32 5: 63 1a fc ff 00 00 00 00 *(u32 *)(r10 - 4) = r1 6: bf a2 00 00 00 00 00 00 r2 = r10 7: 07 02 00 00 fc ff ff ff r2 += -4 ; PidData* pidData = bpf_map_lookup_elem(&pidmap, &pid); 8: 18 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 r1 = 0 ll 10: 85 00 00 00 01 00 00 00 call 1 11: bf 08 00 00 00 00 00 00 r8 = r0 ; if (!pidData) 12: 15 08 15 e8 00 00 00 00 if r8 == 0 goto -6123 <LBB0_27588+0xffffffffffdae100> Note that insn 12 has a branch offset -6123 which is clearly illegal and will be rejected by the verifier. The negative offset is due to the branch range is greater than INT16_MAX. This patch changed the unroll count to be 150 to avoid above branch target insn out-of-range issue. Also the llvm is enhanced ([2]) to assert if the branch target insn is out of INT16 range. [1] https://reviews.llvm.org/D119148 [2] https://reviews.llvm.org/D123877 Signed-off-by: Yonghong Song <yhs@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Link: https://lore.kernel.org/bpf/20220419043230.2928530-1-yhs@fb.com
Diffstat (limited to 'tools/testing/selftests/bpf/progs/exhandler_kern.c')
0 files changed, 0 insertions, 0 deletions