diff options
| author | John Hubbard <jhubbard@nvidia.com> | 2024-05-31 22:07:54 +0200 |
|---|---|---|
| committer | Shuah Khan <skhan@linuxfoundation.org> | 2024-05-31 22:37:10 +0200 |
| commit | 4bf15b1c657d22d1d70173e43264e4606dfe75ff (patch) | |
| tree | d26dd3aab67c490ff93e6d560afe6ac323e78c7c /tools/testing/selftests/futex | |
| parent | selftests/futex: don't redefine .PHONY targets (all, clean) (diff) | |
| download | linux-4bf15b1c657d22d1d70173e43264e4606dfe75ff.tar.xz linux-4bf15b1c657d22d1d70173e43264e4606dfe75ff.zip | |
selftests/futex: don't pass a const char* to asprintf(3)
When building with clang, via:
make LLVM=1 -C tools/testing/selftests
...clang issues this warning:
futex_requeue_pi.c:403:17: warning: passing 'const char **' to parameter
of type 'char **' discards qualifiers in nested pointer types
[-Wincompatible-pointer-types-discards-qualifiers]
This warning fires because test_name is passed into asprintf(3), which
then changes it.
Fix this by simply removing the const qualifier. This is a local
automatic variable in a very short function, so there is not much need
to use the compiler to enforce const-ness at this scope.
[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/
Fixes: f17d8a87ecb5 ("selftests: fuxex: Report a unique test name per run of futex_requeue_pi")
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Diffstat (limited to 'tools/testing/selftests/futex')
| -rw-r--r-- | tools/testing/selftests/futex/functional/futex_requeue_pi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/futex/functional/futex_requeue_pi.c b/tools/testing/selftests/futex/functional/futex_requeue_pi.c index 7f3ca5c78df1..215c6cb539b4 100644 --- a/tools/testing/selftests/futex/functional/futex_requeue_pi.c +++ b/tools/testing/selftests/futex/functional/futex_requeue_pi.c @@ -360,7 +360,7 @@ out: int main(int argc, char *argv[]) { - const char *test_name; + char *test_name; int c, ret; while ((c = getopt(argc, argv, "bchlot:v:")) != -1) { |