diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2022-12-15 03:01:01 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-12-16 11:21:36 +0100 |
| commit | 2fc60e2ff972d3dca836bff0b08cbe503c4ca1ce (patch) | |
| tree | a214fc363d8a860966f62588daf1101820d23f16 /tools/testing | |
| parent | devlink: hold region lock when flushing snapshots (diff) | |
| download | linux-2fc60e2ff972d3dca836bff0b08cbe503c4ca1ce.tar.xz linux-2fc60e2ff972d3dca836bff0b08cbe503c4ca1ce.zip | |
selftests: devlink: fix the fd redirect in dummy_reporter_test
$number + > bash means redirect FD $number, e.g. commonly
used 2> redirects stderr (fd 2). The test uses 8192> to
write the number 8192 to a file, this results in:
./devlink.sh: line 499: 8192: Bad file descriptor
Oddly the test also papers over this issue by checking
for failure (expecting an error rather than success)
so it passes, anyway.
Fixes: ff18176ad806 ("selftests: Add a test of large binary to devlink health test")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing')
| -rwxr-xr-x | tools/testing/selftests/drivers/net/netdevsim/devlink.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh index 9de1d123f4f5..a08c02abde12 100755 --- a/tools/testing/selftests/drivers/net/netdevsim/devlink.sh +++ b/tools/testing/selftests/drivers/net/netdevsim/devlink.sh @@ -496,8 +496,8 @@ dummy_reporter_test() check_reporter_info dummy healthy 3 3 10 true - echo 8192> $DEBUGFS_DIR/health/binary_len - check_fail $? "Failed set dummy reporter binary len to 8192" + echo 8192 > $DEBUGFS_DIR/health/binary_len + check_err $? "Failed set dummy reporter binary len to 8192" local dump=$(devlink health dump show $DL_HANDLE reporter dummy -j) check_err $? "Failed show dump of dummy reporter" |