diff options
| author | Matthieu Baerts (NGI0) <matttbe@kernel.org> | 2024-06-05 11:21:16 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-06-06 17:29:07 +0200 |
| commit | 41b02ea4c0adfcc6761fbfed42c3ce6b6412d881 (patch) | |
| tree | 16c19156a186722fd91eebd98275a9cf4f4f6325 /tools | |
| parent | net: ethtool: fix the error condition in ethtool_get_phy_stats_ethtool() (diff) | |
| download | linux-41b02ea4c0adfcc6761fbfed42c3ce6b6412d881.tar.xz linux-41b02ea4c0adfcc6761fbfed42c3ce6b6412d881.zip | |
selftests: net: lib: support errexit with busywait
If errexit is enabled ('set -e'), loopy_wait -- or busywait and others
using it -- will stop after the first failure.
Note that if the returned status of loopy_wait is checked, and even if
errexit is enabled, Bash will not stop at the first error.
Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Cc: stable@vger.kernel.org
Acked-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Hangbin Liu <liuhangbin@gmail.com>
Link: https://lore.kernel.org/r/20240605-upstream-net-20240605-selftests-net-lib-fixes-v1-1-b3afadd368c9@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/testing/selftests/net/lib.sh | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/tools/testing/selftests/net/lib.sh b/tools/testing/selftests/net/lib.sh index edc030e81a46..a422e10d3d3a 100644 --- a/tools/testing/selftests/net/lib.sh +++ b/tools/testing/selftests/net/lib.sh @@ -67,9 +67,7 @@ loopy_wait() while true do local out - out=$("$@") - local ret=$? - if ((!ret)); then + if out=$("$@"); then echo -n "$out" return 0 fi |