summaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorIan Rogers <irogers@google.com>2021-11-04 07:42:07 +0100
committerArnaldo Carvalho de Melo <acme@redhat.com>2021-11-13 22:11:50 +0100
commit848ddf5999d224050f6cde8c165630fd7671085f (patch)
tree3b0b726b1f801d2ce8b73e93c13ee8e63e46d62e /tools
parentperf test: TSC test, remove is_supported use (diff)
downloadlinux-848ddf5999d224050f6cde8c165630fd7671085f.tar.xz
linux-848ddf5999d224050f6cde8c165630fd7671085f.zip
perf test: Remove is_supported function
All tests now return TEST_SKIP if not supported. Removing this function brings perf's test_suite struct more inline with kunit. Signed-off-by: Ian Rogers <irogers@google.com> Tested-by: Sohaib Mohamed <sohaib.amhmd@gmail.com> Acked-by: Jiri Olsa <jolsa@redhat.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Brendan Higgins <brendanhiggins@google.com> Cc: Daniel Latypov <dlatypov@google.com> Cc: David Gow <davidgow@google.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jin Yao <yao.jin@linux.intel.com> Cc: John Garry <john.garry@huawei.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Clarke <pc@us.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: https://lore.kernel.org/r/20211104064208.3156807-22-irogers@google.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/perf/tests/builtin-test.c14
-rw-r--r--tools/perf/tests/tests.h1
2 files changed, 1 insertions, 14 deletions
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 1d9c0e03b8db..19b1228dbd5d 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -150,11 +150,6 @@ static const char *test_description(const struct test_suite *t, int subtest)
return t->desc;
}
-static bool is_supported(const struct test_suite *t)
-{
- return !t->is_supported || t->is_supported();
-}
-
static test_fnptr test_function(const struct test_suite *t, int subtest)
{
if (subtest <= 0)
@@ -480,12 +475,6 @@ static int __cmd_test(int argc, const char *argv[], struct intlist *skiplist)
continue;
}
- if (!is_supported(t)) {
- pr_debug("%2d: %-*s: Disabled\n", i, width,
- test_description(t, -1));
- continue;
- }
-
pr_info("%2d: %-*s:", i, width, test_description(t, -1));
if (intlist__find(skiplist, i)) {
@@ -583,8 +572,7 @@ static int perf_test__list(int argc, const char **argv)
for_each_test(j, k, t) {
int curr = i++;
- if (!perf_test__matches(test_description(t, -1), curr, argc, argv) ||
- !is_supported(t))
+ if (!perf_test__matches(test_description(t, -1), curr, argc, argv))
continue;
pr_info("%2d: %s\n", i, test_description(t, -1));
diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
index 958f94dcc94c..15051801c790 100644
--- a/tools/perf/tests/tests.h
+++ b/tools/perf/tests/tests.h
@@ -44,7 +44,6 @@ struct test_suite {
bool skip_if_fail;
} subtest;
struct test_case *test_cases;
- bool (*is_supported)(void);
void *priv;
};