diff options
author | Neil Horman <nhorman@openssl.org> | 2024-05-02 14:18:19 +0200 |
---|---|---|
committer | Tomas Mraz <tomas@openssl.org> | 2024-05-02 15:34:21 +0200 |
commit | 067fbc01b9e867b31c71091d62f0f9012dc9e41a (patch) | |
tree | 2dd861842517bd52f03093cdaca9d0522b5904e0 | |
parent | Correct top for EC/DSA nonces if BN_DEBUG is on (diff) | |
download | openssl-067fbc01b9e867b31c71091d62f0f9012dc9e41a.tar.xz openssl-067fbc01b9e867b31c71091d62f0f9012dc9e41a.zip |
Reduce optimization in hppa builds
We're getting some odd errors in the lhash test on hppa. Analysis shows
that the crash is happening randomly in various places, but always
occurs during an indexed load of register r11 or r23. Root cause hasn't
been completely determined, but given that:
1) hppa is an unadopted platform
2) asan/ubsan/threadsan shows no issues with the affected code elsewhere
3) The hppa build does not have threading enabled
4) reducing the optimization level to 01 quashes the problem
The belief is that this is either a bug in gcc optimization, or an issue
in the qemu emulator we use to test.
Since this is causing CI failures, I'm proposing that we just lower the
optimization level of the build to -01 to avoid the problem, and address
it more throughly should an actual platform user encounter an error
Fixes #24272
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/24318)
-rw-r--r-- | .github/workflows/cross-compiles.yml | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/.github/workflows/cross-compiles.yml b/.github/workflows/cross-compiles.yml index 5dc1b83f4e..0d0384c8e5 100644 --- a/.github/workflows/cross-compiles.yml +++ b/.github/workflows/cross-compiles.yml @@ -66,9 +66,11 @@ jobs: target: linux-armv4, tests: -test_includes -test_store -test_x509_store }, { + # gcc hppa seems to have some potential compiler issues + # with -O2 on this platform, reduce optimization to -01 arch: hppa-linux-gnu, libs: libc6-dev-hppa-cross, - target: -static linux-generic32, + target: -static -O1 linux-generic32, fips: no, tests: -test_includes -test_store -test_x509_store }, { |