summaryrefslogtreecommitdiffstats
path: root/crypto/LPdir_vms.c
diff options
context:
space:
mode:
authorRich Salz <rsalz@akamai.com>2015-05-02 05:10:31 +0200
committerRich Salz <rsalz@openssl.org>2015-05-04 21:00:13 +0200
commitb4faea50c35d92a67d1369355b49cc3efba78406 (patch)
treecfebea69d625f936c9fd7281f1fa3eaa2fa38834 /crypto/LPdir_vms.c
parentRT2943: Check sizes if -iv and -K arguments (diff)
downloadopenssl-b4faea50c35d92a67d1369355b49cc3efba78406.tar.xz
openssl-b4faea50c35d92a67d1369355b49cc3efba78406.zip
Use safer sizeof variant in malloc
For a local variable: TYPE *p; Allocations like this are "risky": p = OPENSSL_malloc(sizeof(TYPE)); if the type of p changes, and the malloc call isn't updated, you could get memory corruption. Instead do this: p = OPENSSL_malloc(sizeof(*p)); Also fixed a few memset() calls that I noticed while doing this. Reviewed-by: Richard Levitte <levitte@openssl.org>
Diffstat (limited to 'crypto/LPdir_vms.c')
-rw-r--r--crypto/LPdir_vms.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/crypto/LPdir_vms.c b/crypto/LPdir_vms.c
index 88c7ddd85c..1e8f9e7d61 100644
--- a/crypto/LPdir_vms.c
+++ b/crypto/LPdir_vms.c
@@ -104,12 +104,12 @@ const char *LP_find_file(LP_DIR_CTX **ctx, const char *directory)
return 0;
}
- *ctx = (LP_DIR_CTX *)malloc(sizeof(LP_DIR_CTX));
+ *ctx = malloc(sizeof(**ctx));
if (*ctx == NULL) {
errno = ENOMEM;
return 0;
}
- memset(*ctx, '\0', sizeof(LP_DIR_CTX));
+ memset(*ctx, '\0', sizeof(**ctx));
strcpy((*ctx)->filespec, directory);
strcat((*ctx)->filespec, "*.*;");