diff options
| author | Lennart Poettering <lennart@poettering.net> | 2023-03-07 12:21:10 +0100 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2023-03-09 21:56:42 +0100 |
| commit | e1349c045eb1b3c179732b1db4804109ef282fca (patch) | |
| tree | dd59c6f775b042a0a2b3842c63e8cbe7ee317980 | |
| parent | mountpoint-util: add new fstype_can_umask() helper (diff) | |
| download | systemd-e1349c045eb1b3c179732b1db4804109ef282fca.tar.xz systemd-e1349c045eb1b3c179732b1db4804109ef282fca.zip | |
mountpoint-util: add comment explaining why fstype_can_discard() can't use mount_option_supported()
| -rw-r--r-- | src/basic/mountpoint-util.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/basic/mountpoint-util.c b/src/basic/mountpoint-util.c index 2cb319ba64..e285702388 100644 --- a/src/basic/mountpoint-util.c +++ b/src/basic/mountpoint-util.c @@ -509,9 +509,11 @@ bool fstype_can_umask(const char *fstype) { } bool fstype_can_uid_gid(const char *fstype) { - - /* All file systems that have a uid=/gid= mount option that fixates the owners of all files and directories, - * current and future. */ + /* All file systems that have a uid=/gid= mount option that fixates the owners of all files and + * directories, current and future. Note that this does *not* ask the kernel via + * mount_option_supported() here because the uid=/gid= setting of various file systems mean different + * things: some apply it only to the root dir inode, others to all inodes in the file system. Thus we + * maintain the curated list below. 😢 */ return STR_IN_SET(fstype, "adfs", |