summaryrefslogtreecommitdiffstats
path: root/docs
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2019-04-12 16:50:24 +0200
committerLennart Poettering <lennart@poettering.net>2019-04-12 16:50:24 +0200
commit3b75e079a8d95c53628740f32e06dbe83b88f328 (patch)
treec9efc726c810a9313b4bf2861a47f393df7e42a4 /docs
parentCODING_STYLE: split out section about logging (diff)
downloadsystemd-3b75e079a8d95c53628740f32e06dbe83b88f328.tar.xz
systemd-3b75e079a8d95c53628740f32e06dbe83b88f328.zip
CODING_STYLE: split out section about deadlocks
Diffstat (limited to 'docs')
-rw-r--r--docs/CODING_STYLE.md17
1 files changed, 9 insertions, 8 deletions
diff --git a/docs/CODING_STYLE.md b/docs/CODING_STYLE.md
index 6a743fb493..017a26c696 100644
--- a/docs/CODING_STYLE.md
+++ b/docs/CODING_STYLE.md
@@ -73,14 +73,6 @@ title: Coding Style
- To minimize strict aliasing violations, we prefer unions over casting.
-- Do not issue NSS requests (that includes user name and host name
- lookups) from PID 1 as this might trigger deadlocks when those
- lookups involve synchronously talking to services that we would need
- to start up.
-
-- Do not synchronously talk to any other service from PID 1, due to
- risk of deadlocks.
-
- Be exceptionally careful when formatting and parsing floating point
numbers. Their syntax is locale dependent (i.e. `5.000` in en_US is
generally understood as 5, while in de_DE as 5000.).
@@ -419,6 +411,15 @@ title: Coding Style
headers (i.e those in `src/systemd/sd-*.h`) use integers after all, as `bool`
is C99 and in our public APIs we try to stick to C89 (with a few extension).
+## Deadlocks
+
+- Do not issue NSS requests (that includes user name and host name lookups)
+ from PID 1 as this might trigger deadlocks when those lookups involve
+ synchronously talking to services that we would need to start up.
+
+- Do not synchronously talk to any other service from PID 1, due to risk of
+ deadlocks.
+
## File Descriptors
- When you allocate a file descriptor, it should be made `O_CLOEXEC` right from