analyze: allow verbs to return positive failure

No functional change is intended. The verbs where it wasn't immediately
clear if the success exit status is 0 or >= 0 are changed to explicitly
return 0. (I think it's better to be explicit than to rely on some call
stack always returning 0 on success.)

Some other functions are cleaned up to be more idiomatic.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/analyze/analyze-time.c b/src/analyze/analyze-time.c
index e5744a218e..c233b1f085 100644
--- a/src/analyze/analyze-time.c
+++ b/src/analyze/analyze-time.c
@@ -18,5 +18,5 @@ int verb_time(int argc, char *argv[], void *userdata) {
                 return r;
 
         puts(buf);
-        return 0;
+        return EXIT_SUCCESS;
 }