diff options
| author | Lennart Poettering <lennart@poettering.net> | 2016-05-05 22:24:36 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2016-05-05 22:24:36 +0200 |
| commit | fc2fffe7706ef269005bf4eef56570346c9ca3da (patch) | |
| tree | 9e89ac76ee15de498d97b0d03ed7d764b61874ce /src/libsystemd/sd-daemon | |
| parent | core: use an AF_UNIX/SOCK_DGRAM socket for cgroup agent notification (diff) | |
| download | systemd-fc2fffe7706ef269005bf4eef56570346c9ca3da.tar.xz systemd-fc2fffe7706ef269005bf4eef56570346c9ca3da.zip | |
tree-wide: introduce new SOCKADDR_UN_LEN() macro, and use it everywhere
The macro determines the right length of a AF_UNIX "struct sockaddr_un" to pass to
connect() or bind(). It automatically figures out if the socket refers to an
abstract namespace socket, or a socket in the file system, and properly handles
the full length of the path field.
This macro is not only safer, but also simpler to use, than the usual
offsetof() + strlen() logic.
Diffstat (limited to 'src/libsystemd/sd-daemon')
| -rw-r--r-- | src/libsystemd/sd-daemon/sd-daemon.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/libsystemd/sd-daemon/sd-daemon.c b/src/libsystemd/sd-daemon/sd-daemon.c index bd1c7f15ff..4da9dbfd63 100644 --- a/src/libsystemd/sd-daemon/sd-daemon.c +++ b/src/libsystemd/sd-daemon/sd-daemon.c @@ -458,9 +458,7 @@ _public_ int sd_pid_notify_with_fds(pid_t pid, int unset_environment, const char if (sockaddr.un.sun_path[0] == '@') sockaddr.un.sun_path[0] = 0; - msghdr.msg_namelen = offsetof(struct sockaddr_un, sun_path) + strlen(e); - if (msghdr.msg_namelen > sizeof(struct sockaddr_un)) - msghdr.msg_namelen = sizeof(struct sockaddr_un); + msghdr.msg_namelen = SOCKADDR_UN_LEN(sockaddr.un); have_pid = pid != 0 && pid != getpid(); |