summaryrefslogtreecommitdiffstats
path: root/src/machine/machined-dbus.c
diff options
context:
space:
mode:
authorChris Down <chris@chrisdown.name>2018-12-12 15:58:46 +0100
committerLennart Poettering <lennart@poettering.net>2018-12-12 20:47:40 +0100
commite92aaed30e0b5750e5633765f1bddd51c96678e5 (patch)
treeb568cc092a868d3a4226f529e943d3cde8e72f82 /src/machine/machined-dbus.c
parentMerge pull request #10892 from mbiebl/revert-systemctl-runtime-unmask-breakage (diff)
downloadsystemd-e92aaed30e0b5750e5633765f1bddd51c96678e5.tar.xz
systemd-e92aaed30e0b5750e5633765f1bddd51c96678e5.zip
tree-wide: Remove O_CLOEXEC from fdopen
fdopen doesn't accept "e", it's ignored. Let's not mislead people into believing that it actually sets O_CLOEXEC. From `man 3 fdopen`: > e (since glibc 2.7): > Open the file with the O_CLOEXEC flag. See open(2) for more information. This flag is ignored for fdopen() As mentioned by @jlebon in #11131.
Diffstat (limited to 'src/machine/machined-dbus.c')
-rw-r--r--src/machine/machined-dbus.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/machine/machined-dbus.c b/src/machine/machined-dbus.c
index d613414fde..9afae72ae5 100644
--- a/src/machine/machined-dbus.c
+++ b/src/machine/machined-dbus.c
@@ -615,7 +615,7 @@ static int clean_pool_done(Operation *operation, int ret, sd_bus_error *error) {
if (lseek(operation->extra_fd, 0, SEEK_SET) == (off_t) -1)
return -errno;
- f = fdopen(operation->extra_fd, "re");
+ f = fdopen(operation->extra_fd, "r");
if (!f)
return -errno;