network: move logging from tc .fill_message to the callers

Structured initialization is used a bit more.

There were two kinds of log messages: about failed size calculations and
about failed appends to the message. I "downgraded" the first type to log_debug,
and moved the latter to the caller. This way there should be at most one high-priority
message.

I also changed sizeof(<type>) to sizeof(var) — there is less chance of select-and-paste
error in the second form.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/network/tc/qdisc.c b/src/network/tc/qdisc.c
index 2e0f0a12eb..32b55e99f8 100644
--- a/src/network/tc/qdisc.c
+++ b/src/network/tc/qdisc.c
@@ -210,7 +210,7 @@ int qdisc_configure(Link *link, QDisc *qdisc) {
                 if (QDISC_VTABLE(qdisc)->fill_message) {
                         r = QDISC_VTABLE(qdisc)->fill_message(link, qdisc, req);
                         if (r < 0)
-                                return r;
+                                return log_link_error_errno(link, r, "Could not fill netlink message: %m");
                 }
         } else {
                 r = sd_netlink_message_append_string(req, TCA_KIND, qdisc->tca_kind);