diff options
author | Daan De Meyer <daan.j.demeyer@gmail.com> | 2024-08-30 14:09:06 +0200 |
---|---|---|
committer | Daan De Meyer <daan.j.demeyer@gmail.com> | 2024-09-03 08:49:49 +0200 |
commit | 27cacec939a46f61706d7b48a51b6f5880be4662 (patch) | |
tree | 3fe666eb6357b042e573d1cf284fdba89606e56d /src/partition | |
parent | TEST-58-REPART: Only skip part of testcase_minimize() that requires root (diff) | |
download | systemd-27cacec939a46f61706d7b48a51b6f5880be4662.tar.xz systemd-27cacec939a46f61706d7b48a51b6f5880be4662.zip |
repart: Add compression support
Now that mkfs.btrfs is adding support for compressing the generated
filesystem (https://github.com/kdave/btrfs-progs/pull/882), let's
add general support for specifying the compression algorithm and
compression level to use.
We opt to not parse the specified compression algorithm and instead
pass it on as is to the mkfs tool. This has a few benefits:
- We support every compression algorithm supported by every tool
automatically.
- Users don't need to modify systemd-repart if a mkfs tool learns a
new compression algorithm in the future
- We don't need to maintain a bunch of tables for filesystem to map
from our generic compression algorithm enum to the filesystem specific
names.
We don't add support for btrfs just yet until the corresponding PR
in btrfs-progs is merged.
Diffstat (limited to 'src/partition')
-rw-r--r-- | src/partition/makefs.c | 2 | ||||
-rw-r--r-- | src/partition/repart.c | 79 |
2 files changed, 48 insertions, 33 deletions
diff --git a/src/partition/makefs.c b/src/partition/makefs.c index 53439a4bbc..c76e81d976 100644 --- a/src/partition/makefs.c +++ b/src/partition/makefs.c @@ -78,6 +78,8 @@ static int run(int argc, char *argv[]) { /* discard = */ true, /* quiet = */ true, /* sector_size = */ 0, + /* compression = */ NULL, + /* compression_level = */ NULL, /* extra_mkfs_options = */ NULL); } diff --git a/src/partition/repart.c b/src/partition/repart.c index d770382789..6e76cb011a 100644 --- a/src/partition/repart.c +++ b/src/partition/repart.c @@ -385,6 +385,8 @@ typedef struct Partition { MinimizeMode minimize; uint64_t verity_data_block_size; uint64_t verity_hash_block_size; + char *compression; + char *compression_level; uint64_t gpt_flags; int no_auto; @@ -545,6 +547,8 @@ static Partition* partition_free(Partition *p) { ordered_hashmap_free(p->subvolumes); free(p->default_subvolume); free(p->verity_match_key); + free(p->compression); + free(p->compression_level); iovec_done(&p->roothash); @@ -581,6 +585,8 @@ static void partition_foreignize(Partition *p) { p->subvolumes = ordered_hashmap_free(p->subvolumes); p->default_subvolume = mfree(p->default_subvolume); p->verity_match_key = mfree(p->verity_match_key); + p->compression = mfree(p->compression); + p->compression_level = mfree(p->compression_level); p->priority = 0; p->weight = 1000; @@ -2088,38 +2094,40 @@ static int partition_finalize_fstype(Partition *p, const char *path) { static int partition_read_definition(Partition *p, const char *path, const char *const *conf_file_dirs) { ConfigTableItem table[] = { - { "Partition", "Type", config_parse_type, 0, &p->type }, - { "Partition", "Label", config_parse_label, 0, &p->new_label }, - { "Partition", "UUID", config_parse_uuid, 0, p }, - { "Partition", "Priority", config_parse_int32, 0, &p->priority }, - { "Partition", "Weight", config_parse_weight, 0, &p->weight }, - { "Partition", "PaddingWeight", config_parse_weight, 0, &p->padding_weight }, - { "Partition", "SizeMinBytes", config_parse_size4096, -1, &p->size_min }, - { "Partition", "SizeMaxBytes", config_parse_size4096, 1, &p->size_max }, - { "Partition", "PaddingMinBytes", config_parse_size4096, -1, &p->padding_min }, - { "Partition", "PaddingMaxBytes", config_parse_size4096, 1, &p->padding_max }, - { "Partition", "FactoryReset", config_parse_bool, 0, &p->factory_reset }, - { "Partition", "CopyBlocks", config_parse_copy_blocks, 0, p }, - { "Partition", "Format", config_parse_fstype, 0, &p->format }, - { "Partition", "CopyFiles", config_parse_copy_files, 0, &p->copy_files }, - { "Partition", "ExcludeFiles", config_parse_exclude_files, 0, &p->exclude_files_source }, - { "Partition", "ExcludeFilesTarget", config_parse_exclude_files, 0, &p->exclude_files_target }, - { "Partition", "MakeDirectories", config_parse_make_dirs, 0, &p->make_directories }, - { "Partition", "Encrypt", config_parse_encrypt, 0, &p->encrypt }, - { "Partition", "Verity", config_parse_verity, 0, &p->verity }, - { "Partition", "VerityMatchKey", config_parse_string, 0, &p->verity_match_key }, - { "Partition", "Flags", config_parse_gpt_flags, 0, &p->gpt_flags }, - { "Partition", "ReadOnly", config_parse_tristate, 0, &p->read_only }, - { "Partition", "NoAuto", config_parse_tristate, 0, &p->no_auto }, - { "Partition", "GrowFileSystem", config_parse_tristate, 0, &p->growfs }, - { "Partition", "SplitName", config_parse_string, 0, &p->split_name_format }, - { "Partition", "Minimize", config_parse_minimize, 0, &p->minimize }, - { "Partition", "Subvolumes", config_parse_subvolumes, 0, &p->subvolumes }, - { "Partition", "DefaultSubvolume", config_parse_default_subvolume, 0, &p->default_subvolume }, - { "Partition", "VerityDataBlockSizeBytes", config_parse_block_size, 0, &p->verity_data_block_size }, - { "Partition", "VerityHashBlockSizeBytes", config_parse_block_size, 0, &p->verity_hash_block_size }, - { "Partition", "MountPoint", config_parse_mountpoint, 0, p }, - { "Partition", "EncryptedVolume", config_parse_encrypted_volume, 0, p }, + { "Partition", "Type", config_parse_type, 0, &p->type }, + { "Partition", "Label", config_parse_label, 0, &p->new_label }, + { "Partition", "UUID", config_parse_uuid, 0, p }, + { "Partition", "Priority", config_parse_int32, 0, &p->priority }, + { "Partition", "Weight", config_parse_weight, 0, &p->weight }, + { "Partition", "PaddingWeight", config_parse_weight, 0, &p->padding_weight }, + { "Partition", "SizeMinBytes", config_parse_size4096, -1, &p->size_min }, + { "Partition", "SizeMaxBytes", config_parse_size4096, 1, &p->size_max }, + { "Partition", "PaddingMinBytes", config_parse_size4096, -1, &p->padding_min }, + { "Partition", "PaddingMaxBytes", config_parse_size4096, 1, &p->padding_max }, + { "Partition", "FactoryReset", config_parse_bool, 0, &p->factory_reset }, + { "Partition", "CopyBlocks", config_parse_copy_blocks, 0, p }, + { "Partition", "Format", config_parse_fstype, 0, &p->format }, + { "Partition", "CopyFiles", config_parse_copy_files, 0, &p->copy_files }, + { "Partition", "ExcludeFiles", config_parse_exclude_files, 0, &p->exclude_files_source }, + { "Partition", "ExcludeFilesTarget", config_parse_exclude_files, 0, &p->exclude_files_target }, + { "Partition", "MakeDirectories", config_parse_make_dirs, 0, &p->make_directories }, + { "Partition", "Encrypt", config_parse_encrypt, 0, &p->encrypt }, + { "Partition", "Verity", config_parse_verity, 0, &p->verity }, + { "Partition", "VerityMatchKey", config_parse_string, 0, &p->verity_match_key }, + { "Partition", "Flags", config_parse_gpt_flags, 0, &p->gpt_flags }, + { "Partition", "ReadOnly", config_parse_tristate, 0, &p->read_only }, + { "Partition", "NoAuto", config_parse_tristate, 0, &p->no_auto }, + { "Partition", "GrowFileSystem", config_parse_tristate, 0, &p->growfs }, + { "Partition", "SplitName", config_parse_string, 0, &p->split_name_format }, + { "Partition", "Minimize", config_parse_minimize, 0, &p->minimize }, + { "Partition", "Subvolumes", config_parse_subvolumes, 0, &p->subvolumes }, + { "Partition", "DefaultSubvolume", config_parse_default_subvolume, 0, &p->default_subvolume }, + { "Partition", "VerityDataBlockSizeBytes", config_parse_block_size, 0, &p->verity_data_block_size }, + { "Partition", "VerityHashBlockSizeBytes", config_parse_block_size, 0, &p->verity_hash_block_size }, + { "Partition", "MountPoint", config_parse_mountpoint, 0, p }, + { "Partition", "EncryptedVolume", config_parse_encrypted_volume, 0, p }, + { "Partition", "Compression", config_parse_string, CONFIG_PARSE_STRING_SAFE_AND_ASCII, &p->compression }, + { "Partition", "CompressionLevel", config_parse_string, CONFIG_PARSE_STRING_SAFE_AND_ASCII, &p->compression_level }, {} }; _cleanup_free_ char *filename = NULL; @@ -5469,7 +5477,8 @@ static int context_mkfs(Context *context) { r = make_filesystem(partition_target_path(t), p->format, strempty(p->new_label), root, p->fs_uuid, arg_discard, /* quiet = */ false, - context->fs_sector_size, extra_mkfs_options); + context->fs_sector_size, p->compression, p->compression_level, + extra_mkfs_options); if (r < 0) return r; @@ -7033,6 +7042,8 @@ static int context_minimize(Context *context) { fs_uuid, arg_discard, /* quiet = */ false, context->fs_sector_size, + p->compression, + p->compression_level, extra_mkfs_options); if (r < 0) return r; @@ -7114,6 +7125,8 @@ static int context_minimize(Context *context) { arg_discard, /* quiet = */ false, context->fs_sector_size, + p->compression, + p->compression_level, extra_mkfs_options); if (r < 0) return r; |