diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2017-05-13 17:26:55 +0200 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2017-05-19 20:24:03 +0200 |
commit | 25f027c5efb2a26b2c7cb9a9608eb2bd49cc5ffc (patch) | |
tree | a06ce3e12ccf6ada4027bd2f2994ad5727b3658f /src/stdio-bridge/stdio-bridge.c | |
parent | tree-wide: fix incorrect uses of %m (diff) | |
download | systemd-25f027c5efb2a26b2c7cb9a9608eb2bd49cc5ffc.tar.xz systemd-25f027c5efb2a26b2c7cb9a9608eb2bd49cc5ffc.zip |
tree-wide: when %m is used in log_*, always specify errno explicitly
All those uses were correct, but I think it's better to be explicit.
Using implicit errno is too error prone, and with this change we can require
(in the sense of a style guideline) that the code is always specified.
Helpful query: git grep -n -P 'log_[^s][a-z]+\(.*%m'
Diffstat (limited to 'src/stdio-bridge/stdio-bridge.c')
-rw-r--r-- | src/stdio-bridge/stdio-bridge.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/stdio-bridge/stdio-bridge.c b/src/stdio-bridge/stdio-bridge.c index 02ba5269dd..097f8c1a4b 100644 --- a/src/stdio-bridge/stdio-bridge.c +++ b/src/stdio-bridge/stdio-bridge.c @@ -292,7 +292,7 @@ int main(int argc, char *argv[]) { r = ppoll(p, ELEMENTSOF(p), ts, NULL); } if (r < 0) { - log_error("ppoll() failed: %m"); + log_error_errno(errno, "ppoll() failed: %m"); goto finish; } } |