summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorYu Watanabe <watanabe.yu+github@gmail.com>2021-10-24 21:39:10 +0200
committerYu Watanabe <watanabe.yu+github@gmail.com>2021-10-27 09:41:04 +0200
commit68cbac5bd43168b310664911a50a8b46b313108a (patch)
treeee10385620278feacfd17496bd5baf6a0dded230 /src
parentsd-radv: use assert_return() (diff)
downloadsystemd-68cbac5bd43168b310664911a50a8b46b313108a.tar.xz
systemd-68cbac5bd43168b310664911a50a8b46b313108a.zip
sd-radv: use IPv6 specific functions
Diffstat (limited to 'src')
-rw-r--r--src/libsystemd-network/sd-radv.c26
1 files changed, 9 insertions, 17 deletions
diff --git a/src/libsystemd-network/sd-radv.c b/src/libsystemd-network/sd-radv.c
index 9030150aee..83ef158ebf 100644
--- a/src/libsystemd-network/sd-radv.c
+++ b/src/libsystemd-network/sd-radv.c
@@ -556,9 +556,7 @@ _public_ int sd_radv_add_prefix(sd_radv *ra, sd_radv_prefix *p, int dynamic) {
if (in6_addr_is_null(&p->opt.in6_addr))
return -ENOEXEC;
- (void) in_addr_prefix_to_string(AF_INET6,
- (const union in_addr_union*) &p->opt.in6_addr,
- p->opt.prefixlen, &addr_p);
+ (void) in6_addr_prefix_to_string(&p->opt.in6_addr, p->opt.prefixlen, &addr_p);
LIST_FOREACH(prefix, cur, ra->prefixes) {
@@ -576,9 +574,7 @@ _public_ int sd_radv_add_prefix(sd_radv *ra, sd_radv_prefix *p, int dynamic) {
goto update;
_cleanup_free_ char *addr_cur = NULL;
- (void) in_addr_prefix_to_string(AF_INET6,
- (const union in_addr_union*) &cur->opt.in6_addr,
- cur->opt.prefixlen, &addr_cur);
+ (void) in6_addr_prefix_to_string(&cur->opt.in6_addr, cur->opt.prefixlen, &addr_cur);
return log_radv_errno(ra, SYNTHETIC_ERRNO(EEXIST),
"IPv6 prefix %s already configured, ignoring %s",
strna(addr_cur), strna(addr_p));
@@ -659,16 +655,14 @@ _public_ sd_radv_prefix *sd_radv_remove_prefix(sd_radv *ra,
_public_ int sd_radv_add_route_prefix(sd_radv *ra, sd_radv_route_prefix *p, int dynamic) {
usec_t time_now, valid, valid_until;
- _cleanup_free_ char *pretty = NULL;
+ _cleanup_free_ char *addr_p = NULL;
sd_radv_route_prefix *cur;
int r;
assert_return(ra, -EINVAL);
assert_return(p, -EINVAL);
- (void) in_addr_prefix_to_string(AF_INET6,
- (const union in_addr_union*) &p->opt.in6_addr,
- p->opt.prefixlen, &pretty);
+ (void) in6_addr_prefix_to_string(&p->opt.in6_addr, p->opt.prefixlen, &addr_p);
LIST_FOREACH(prefix, cur, ra->route_prefixes) {
@@ -685,13 +679,11 @@ _public_ int sd_radv_add_route_prefix(sd_radv *ra, sd_radv_route_prefix *p, int
if (dynamic && cur->opt.prefixlen == p->opt.prefixlen)
goto update;
- _cleanup_free_ char *addr = NULL;
- (void) in_addr_prefix_to_string(AF_INET6,
- (const union in_addr_union*) &cur->opt.in6_addr,
- cur->opt.prefixlen, &addr);
+ _cleanup_free_ char *addr_cur = NULL;
+ (void) in6_addr_prefix_to_string(&cur->opt.in6_addr, cur->opt.prefixlen, &addr_cur);
return log_radv_errno(ra, SYNTHETIC_ERRNO(EEXIST),
"IPv6 route prefix %s already configured, ignoring %s",
- strna(addr), strna(pretty));
+ strna(addr_cur), strna(addr_p));
}
p = sd_radv_route_prefix_ref(p);
@@ -700,7 +692,7 @@ _public_ int sd_radv_add_route_prefix(sd_radv *ra, sd_radv_route_prefix *p, int
ra->n_route_prefixes++;
if (!dynamic) {
- log_radv(ra, "Added prefix %s", strna(pretty));
+ log_radv(ra, "Added prefix %s", strna(addr_p));
return 0;
}
@@ -724,7 +716,7 @@ _public_ int sd_radv_add_route_prefix(sd_radv *ra, sd_radv_route_prefix *p, int
return -EOVERFLOW;
log_radv(ra, "Updated route prefix %s valid %s",
- strna(pretty),
+ strna(addr_p),
FORMAT_TIMESPAN(valid, USEC_PER_SEC));
return 0;