diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-05-14 17:33:54 +0200 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-05-14 17:34:38 +0200 |
commit | 6f1d18ae9319bad3d13b90caa6dc0b34ea0a1b10 (patch) | |
tree | b484218e098cba75bb90c9dc56184380ced1f8d3 /src | |
parent | resolved: drop pointless bitfield on a lone bool (diff) | |
download | systemd-6f1d18ae9319bad3d13b90caa6dc0b34ea0a1b10.tar.xz systemd-6f1d18ae9319bad3d13b90caa6dc0b34ea0a1b10.zip |
resolved: inline iterator variable declarations
Diffstat (limited to 'src')
-rw-r--r-- | src/resolve/resolved-dns-dnssec.c | 14 | ||||
-rw-r--r-- | src/resolve/resolved-dns-rr.c | 4 |
2 files changed, 6 insertions, 12 deletions
diff --git a/src/resolve/resolved-dns-dnssec.c b/src/resolve/resolved-dns-dnssec.c index 70d7837a3a..4fa3c1d995 100644 --- a/src/resolve/resolved-dns-dnssec.c +++ b/src/resolve/resolved-dns-dnssec.c @@ -35,7 +35,6 @@ uint16_t dnssec_keytag(DnsResourceRecord *dnskey, bool mask_revoke) { const uint8_t *p; uint32_t sum, f; - size_t i; /* The algorithm from RFC 4034, Appendix B. */ @@ -51,7 +50,7 @@ uint16_t dnssec_keytag(DnsResourceRecord *dnskey, bool mask_revoke) { p = dnskey->dnskey.key; - for (i = 0; i < dnskey->dnskey.key_size; i++) + for (size_t i = 0; i < dnskey->dnskey.key_size; i++) sum += (i & 1) == 0 ? (uint32_t) p[i] << 8 : (uint32_t) p[i]; sum += (sum >> 16) & UINT32_C(0xFFFF); @@ -605,13 +604,11 @@ static void dnssec_fix_rrset_ttl( DnsResourceRecord *rrsig, usec_t realtime) { - unsigned k; - assert(list); assert(n > 0); assert(rrsig); - for (k = 0; k < n; k++) { + for (unsigned k = 0; k < n; k++) { DnsResourceRecord *rr = list[k]; /* Pick the TTL as the minimum of the RR's TTL, the @@ -641,7 +638,7 @@ int dnssec_verify_rrset( const char *source, *name; _cleanup_(gcry_md_closep) gcry_md_hd_t md = NULL; int r, md_algorithm; - size_t k, n = 0; + size_t n = 0; size_t sig_size = 0; _cleanup_free_ char *sig_data = NULL; _cleanup_fclose_ FILE *f = NULL; @@ -771,7 +768,7 @@ int dnssec_verify_rrset( if (r < 0) return r; - for (k = 0; k < n; k++) { + for (size_t k = 0; k < n; k++) { size_t l; rr = list[k]; @@ -1211,7 +1208,6 @@ int dnssec_nsec3_hash(DnsResourceRecord *nsec3, const char *name, void *ret) { size_t hash_size; int algorithm; void *result; - unsigned k; int r; assert(nsec3); @@ -1253,7 +1249,7 @@ int dnssec_nsec3_hash(DnsResourceRecord *nsec3, const char *name, void *ret) { if (!result) return -EIO; - for (k = 0; k < nsec3->nsec3.iterations; k++) { + for (unsigned k = 0; k < nsec3->nsec3.iterations; k++) { uint8_t tmp[hash_size]; memcpy(tmp, result, hash_size); diff --git a/src/resolve/resolved-dns-rr.c b/src/resolve/resolved-dns-rr.c index e493c32158..5d59a90a8e 100644 --- a/src/resolve/resolved-dns-rr.c +++ b/src/resolve/resolved-dns-rr.c @@ -795,14 +795,12 @@ static char *format_txt(DnsTxtItem *first) { return NULL; LIST_FOREACH(items, i, first) { - size_t j; - if (i != first) *(p++) = ' '; *(p++) = '"'; - for (j = 0; j < i->length; j++) { + for (size_t j = 0; j < i->length; j++) { if (i->data[j] < ' ' || i->data[j] == '"' || i->data[j] >= 127) { *(p++) = '\\'; *(p++) = '0' + (i->data[j] / 100); |