diff options
author | Lennart Poettering <lennart@poettering.net> | 2019-11-19 18:54:47 +0100 |
---|---|---|
committer | Lennart Poettering <lennart@poettering.net> | 2019-11-20 09:39:54 +0100 |
commit | b82e818f5cc919187630bce88fc5d5ded0f51d23 (patch) | |
tree | 8ffbb73a85012c7b153a4e4540b1aaca2825bdb0 /test/TEST-20-MAINPIDGAMES | |
parent | Merge pull request #14085 from poettering/ask-password-api (diff) | |
download | systemd-b82e818f5cc919187630bce88fc5d5ded0f51d23.tar.xz systemd-b82e818f5cc919187630bce88fc5d5ded0f51d23.zip |
test: make sure our tests get exclusive TTY access
This sould make our test suite a bit more robust if it is slow running.
A few of our test services use StandardOutput=tty or StandardError=tty
in the tests in order to connect test services to the container console.
This gets into conflict with the container getty which wants exclusive
access to the console. Since the container getty is started with
Type=idle it typically gets started after a timeout only if the TTY is
already used, which hence introduces a race: if the test finishes
earlier all is good, if not, then the test gets kicked off the TTY which
then causes bash to abort since it cannot write any error messages
anymore.
Let's fix this hence: all tests that connect to the tty are now
synchronized to getty-pre.target, so they finish before any getty is
started.
Diffstat (limited to 'test/TEST-20-MAINPIDGAMES')
-rwxr-xr-x | test/TEST-20-MAINPIDGAMES/test.sh | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/test/TEST-20-MAINPIDGAMES/test.sh b/test/TEST-20-MAINPIDGAMES/test.sh index 0ba30bdb00..05fa847a65 100755 --- a/test/TEST-20-MAINPIDGAMES/test.sh +++ b/test/TEST-20-MAINPIDGAMES/test.sh @@ -18,6 +18,8 @@ test_setup() { cat >$initdir/etc/systemd/system/testsuite.service <<EOF [Unit] Description=Testsuite service +Before=getty-pre.target +Wants=getty-pre.target [Service] ExecStart=/bin/bash -x /testsuite.sh |