diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2024-01-07 11:02:05 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2024-01-22 12:29:33 +0100 |
| commit | 0650006a93a2ce3b57f86e7f000347d9ae7737ef (patch) | |
| tree | ff8698014b87df2f243e56963e2fe2b719535468 | |
| parent | dmaengine: fsl-qdma: Fix a memory leak related to the queue command DMA (diff) | |
| download | linux-0650006a93a2ce3b57f86e7f000347d9ae7737ef.tar.xz linux-0650006a93a2ce3b57f86e7f000347d9ae7737ef.zip | |
dmaengine: fsl-qdma: Remove a useless devm_kfree()
'status_head' is a managed resource. It will be freed automatically if
fsl_qdma_prep_status_queue(), and so fsl_qdma_probe(), fails.
Remove the redundant (and harmless) devm_kfree() call.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/6b7f60aa2b92f73b35c586886daffc1a5ac58697.1704621515.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/fsl-qdma.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/dma/fsl-qdma.c b/drivers/dma/fsl-qdma.c index 9b141369bea5..f405c77060ad 100644 --- a/drivers/dma/fsl-qdma.c +++ b/drivers/dma/fsl-qdma.c @@ -568,10 +568,9 @@ static struct fsl_qdma_queue status_size, &status_head->bus_addr, GFP_KERNEL); - if (!status_head->cq) { - devm_kfree(&pdev->dev, status_head); + if (!status_head->cq) return NULL; - } + status_head->n_cq = status_size; status_head->virt_head = status_head->cq; status_head->virt_tail = status_head->cq; |